Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly Enable Lints #425

Closed
5 tasks done
JP-Ellis opened this issue Oct 19, 2023 · 1 comment · Fixed by #426
Closed
5 tasks done

Properly Enable Lints #425

JP-Ellis opened this issue Oct 19, 2023 · 1 comment · Fixed by #426
Assignees
Labels
smartbear-supported This issue is supported by SmartBear type:feature New feature

Comments

@JP-Ellis
Copy link
Contributor

JP-Ellis commented Oct 19, 2023

Have you read the Contributing Guidelines on issues?

Description

  • Configures Mypy, Ruff and Black to exclude v2 files
  • Enables the lint CI workflow
  • Fix lints which were previously missed.

Has this been requested on Canny?

No response

Motivation

Formatting rules help ensure there is a consistent style applied across the entire codebase, and linting rules help catch potential issues, and help ensure best practices are followed.

As there is a significant existing codebase which will eventually be deprecated, there is little benefit to applying formatting and linting rules to the files which are to be deprecated. As a result, the rules need to be exclude the existing (v2) files.

Have you tried building it?

No response

Self-service

  • I'd be willing to contribute this feature to Pact Python myself.
@JP-Ellis JP-Ellis added smartbear-supported This issue is supported by SmartBear type:feature New feature labels Oct 19, 2023
@JP-Ellis JP-Ellis moved this to 👀 In Review in Pact Python Oct 19, 2023
@github-actions
Copy link

🤖 Great news! We've labeled this issue as smartbear-supported and created a tracking ticket in PactFlow's Jira (PACT-1426). We'll keep work public and post updates here. Meanwhile, feel free to check out our docs. Thanks for your patience!

@JP-Ellis JP-Ellis self-assigned this Oct 19, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Completed in Pact Python Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smartbear-supported This issue is supported by SmartBear type:feature New feature
Projects
Status: ✅ Completed
Development

Successfully merging a pull request may close this issue.

1 participant