Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why have next as peer dependency #159

Closed
dimaMachina opened this issue Dec 19, 2022 · 2 comments · Fixed by #186
Closed

Why have next as peer dependency #159

dimaMachina opened this issue Dec 19, 2022 · 2 comments · Fixed by #186
Labels
enhancement New feature or request

Comments

@dimaMachina
Copy link
Contributor

Any reason to have next as peer deps ?

next-themes/package.json

Line 20 in 8fc17e2

"next": "*",

I think next-themes can be React framework agnostic since next-themes doesn't use next somewhere 🤔.
@ronildo
Copy link

ronildo commented Apr 20, 2023

Any update on this? I would love to use it in my project, but it's not a Next project.

@pacocoursey pacocoursey added the enhancement New feature or request label Apr 21, 2023
@dimaMachina dimaMachina mentioned this issue Jun 12, 2023
Open
@dimaMachina dimaMachina mentioned this issue Jun 23, 2023
Merged
@dimaMachina dimaMachina mentioned this issue Jul 6, 2023
Closed
@RIP21
Copy link

RIP21 commented Jul 6, 2023

Any update on this? I would love to use it in my project, but it's not a Next project.

Just use it. Patch peerDependencies and that's about it.

Package is pretty simple, so you can always fork :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make next-themes react agnostic dimaMachina/next-themes
4 participants
@ronildo @RIP21 @dimaMachina @pacocoursey