Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Convention] Aria attributes should not be used to style components #77

Closed
frykten opened this issue Jan 30, 2023 · 1 comment
Closed

[Convention] Aria attributes should not be used to style components #77

frykten opened this issue Jan 30, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@frykten
Copy link

frykten commented Jan 30, 2023

Hi!

We've had issues when trying to style a CmdK Select Item: we have to use the aria-selected attribute to style the items, even though it goes against our principles/conventions (aria-attributes should not be used to style elements).

Meanwhile, Radix has implemented a data-highlighted custom attribute to fix that issue. Could you do the same, please? I'm willing to dig into the code and make a PR, if necessary.
@pacocoursey pacocoursey added enhancement New feature or request good first issue Good for newcomers labels Jan 30, 2023
@prestonbourne prestonbourne mentioned this issue Feb 6, 2023
Merged
@pacocoursey
Copy link
Owner

Fixed and released in 0.1.22:

npm i [email protected]

@joaom00 joaom00 mentioned this issue Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frykten @pacocoursey