Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video player opening or closing got very slow #920

Closed
Jasdemi opened this issue Aug 31, 2024 · 1 comment · Fixed by #922
Closed

Video player opening or closing got very slow #920

Jasdemi opened this issue Aug 31, 2024 · 1 comment · Fixed by #922
Assignees

Comments

@Jasdemi
Copy link

Jasdemi commented Aug 31, 2024

Describe the bug
Since the 2.8.0 update, the video player takes way longer to open or close.

To Reproduce
Steps to reproduce the behavior:

  1. Watch any video

Expected behavior
Instantly open and close video player like in 2.7.1

Screenshots or video

VID_20240831_140252_635.mp4

Versions
Pachli 2.8.0

Device:
Google Pixel 6a
Android version: 14
SDK level: 34

Account:
@[email protected]
Version: 0.16.1-SNAPSHOT+git-88a81fb

Affirmation
I have checked other issues for this project (open and closed) and I cannot find one that matches the problem I am reporting.

@nikclayton
Copy link
Contributor

nikclayton commented Sep 3, 2024

Some investigation shows this is an androidx-media3 change. It's OK at version 1.3.1, advancing to version 1.4.0 or 1.4.1 causes the fragment transition to no longer be smooth. Further investigation required.

Edit: Known bug in androidx-media3 that breaks shared element transitions.

nikclayton added a commit that referenced this issue Sep 3, 2024
androidx.media3 1.4.0-rc01 and above (at the time of writing) has a
bug that breaks shared element transitions with a `PlayerView` (see
androidx/media#1594).

This can be worked around by setting `app:surface_type="texture_view"`.
This uses more power, but for the typical length of social media videos
this shouldn't be a problem at the moment.

Fixes #920.
@github-project-automation github-project-automation bot moved this from Todo to Done in Pachli roadmap Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants