Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Android User Experience #27

Open
5 tasks
alltheseas opened this issue Apr 17, 2024 · 13 comments
Open
5 tasks

Improve Android User Experience #27

alltheseas opened this issue Apr 17, 2024 · 13 comments

Comments

@alltheseas
Copy link

alltheseas commented Apr 17, 2024

Good

"Pop-up" works by default - opens in new tab. No need to go settings spelunking to unblock a pop-up (see counterpoint in #22).

1

Password manager on chromium recognizes password on wikifreedia/nsecbunker keys creation.

Bad

  • After creating an account, when I first attempt to create a new entry, and hit the "+" (i.e. create new entry icon) nothing happens. I have to hit the + icon again, and an enter a slightly different name to open a new wiki entry.

  • Keyboard is not usable after I open a blank new entry. When I start entering some characters and words, delete button ends up adding more text.

Ugly

  • Write requests occur in new tab/pop-up. This is poor UX on mobile. Ideally it all happens in one tab.

2

  • Nsecbunker auth boxes - i.e. displaying full npub, and other message is designed for desktop only. Screen is cut off. Mobile real estate redesign is sorely needed.

3

  • Screen is not centered, as it is not designed for vertical device.

4

More cut off.

5

6

related

#22

@dtonon
Copy link

dtonon commented Apr 17, 2024

@alltheseas please add some basic info about the system you are using: Android version and browser name/version.

I suspect that the horizontal scrolling of the modal (window.nostr.js) is created by the underlying page that itself does not respect the width of the screen.

@alltheseas
Copy link
Author

pixel 6
grapheneOS
version 14
android
versionCode 34
targetSdk 34
minSdk 34
IMG_20240417_120357
IMG_20240417_120255

@dtonon
Copy link

dtonon commented Apr 18, 2024

Write requests occur in new tab/pop-up. This is poor UX on mobile. Ideally it all happens in one tab.

See #22 (comment)

Nsecbunker auth boxes - i.e. displaying full npub, and other message is designed for desktop only. Screen is cut off. Mobile real estate redesign is sorely needed.

Screen is not centered, as it is not designed for vertical device.

More cut off

The problem is not strictly related to window.nostr.js (the blu modal), it happens because the underlying page is not fully responsive (the top menu does not wrap and so it pushes the page width).

PS: you uploaded images at 1080 × 2400px, they are rendered huge and so this make difficult to scroll/read the post or even see the images themselves; I suggest you to resize them before the upload, probably an height of 600px is enough.

@fiatjaf
Copy link
Contributor

fiatjaf commented Apr 19, 2024

@dtonon can't we just set the window.nostr.js popup width there to 100vw to it always takes the full screen and nothing more or less, regardless of the size of the underlying page?

@fiatjaf
Copy link
Contributor

fiatjaf commented Apr 19, 2024

Ugly
Write requests occur in new tab/pop-up. This is poor UX on mobile. Ideally it all happens in one tab.

There is no way around this, but I don't see why it would be so bad. If the user knows their account lives in a different server or they're running an nsecbunker this should come at no surprise to them.

@dtonon
Copy link

dtonon commented Apr 19, 2024

@fiatjaf

@dtonon can't we just set the window.nostr.js popup width there to 100vw

Yes, it should work

@alltheseas
Copy link
Author

If the user knows their account lives in a different server or they're running an nsecbunker this should come at no surprise to them.

Today's nostr users who are tinkering with wikifreedia would probably know this.

Outside this subset this is a friction point.

If "there is no way around this", so be it.

I ask yall galaxy brain devs to double check this (new tabs/pop-ups required) is the case.

@fiatjaf
Copy link
Contributor

fiatjaf commented Apr 19, 2024

We're going to solve it all with hard cryptography.

@alltheseas
Copy link
Author

you uploaded images at 1080 × 2400px, they are rendered huge and so this make difficult to scroll/read the post or even see the images themselves; I suggest you to resize them before the upload, probably an height of 600px is enough.

@dtonon replaced the images, thanks for the feedback

@alltheseas
Copy link
Author

We're going to solve it all with hard cryptography.

@fiatjaf - thank you for inspiring me. See you soon

nostrworld/nostriga#7

@dtonon
Copy link

dtonon commented Apr 20, 2024

We found a fix, it will be deployed asap.
fiatjaf/window.nostr.js@53f6a4d

wikifreedia-android.mp4

@alltheseas
Copy link
Author

We found a fix, it will be deployed asap.

What was the fix?

Lmk when ready - happy to test.

@dtonon
Copy link

dtonon commented Apr 20, 2024

I linked the commit with all the info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants