Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.7.1 stopped sending coverage comments. #235

Closed
dashmug opened this issue Sep 28, 2020 · 9 comments · Fixed by #236 or #238
Closed

v2.7.1 stopped sending coverage comments. #235

dashmug opened this issue Sep 28, 2020 · 9 comments · Fixed by #236 or #238
Assignees
Labels
bug Something isn't working

Comments

@dashmug
Copy link

dashmug commented Sep 28, 2020

Describe the bug
CodeClimate coverage comments stopped updating after upgrading. I believe there were some failures in sending the coverage data to CodeClimate.

I'm referring to this:

Screen Shot 2020-09-28 at 10 40 00 am

Version v2.6.0 works without problems. I have reverted back to it in the mean time.

Version of codeclimate-action you're using
v2.7.1

Example links
I'll post some screenshots when I get the time.

Expected behavior
It will continue behaving as it was before.

Additional context
TODO

@dashmug dashmug added the bug Something isn't working label Sep 28, 2020
@bennypowers
Copy link
Contributor

I experienced this as well:

https://github.com/apollo-elements/apollo-elements/runs/1189033952?check_suite_focus=true

0 seconds, no console output

@paambaati
Copy link
Owner

@bennypowers Would you mind turning on debug mode and sharing the results here? You can set the debug option to true.

@paambaati
Copy link
Owner

@dashmug The attached screenshot shows the codeclimate bot, which has nothing to do with this action. Can you help me understand how that is relevant here?

@dashmug
Copy link
Author

dashmug commented Oct 1, 2020

@paambaati It is relevant because it means CodeClimate did not receive any coverage data so the bot isn't triggered to do anything.

@paambaati
Copy link
Owner

@dashmug @bennypowers I was able to figure out the issue and I've now pushed a new release - please try v2.7.2 and reopen this issue if the problem persists.

@dashmug
Copy link
Author

dashmug commented Oct 1, 2020

@paambaati v2.7.2 fixed it. Thank you very much.

@bennypowers
Copy link
Contributor

Thanks for the update

Run paambaati/[email protected]
  with:
    coverageCommand: yarn coverage
    debug: false
  env:
    CC_TEST_REPORTER_ID: ***
/home/runner/work/apollo-elements/apollo-elements/cc-reporter before-build
/usr/bin/yarn coverage
yarn run v1.18.0
error Command "coverage" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
(node:3556) UnhandledPromiseRejectionWarning: Error: The process '/usr/bin/yarn' failed with exit code 1
Error: The process '/usr/bin/yarn' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/paambaati/codeclimate-action/v2.7.2/node_modules/@actions/exec/lib/toolrunner.js:574:25)
    at ExecState.CheckComplete (/home/runner/work/_actions/paambaati/codeclimate-action/v2.7.2/node_modules/@actions/exec/lib/toolrunner.js:557:18)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/paambaati/codeclimate-action/v2.7.2/node_modules/@actions/exec/lib/toolrunner.js:451:27)
    at ChildProcess.emit (events.js:210:5)
    at maybeClose (internal/child_process.js:1021:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)
Error: 🚨 Coverage run failed!
(node:3556) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:3556) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
      - name: Test
        run: yarn test

      - name: Test & Publish Code Coverage
        uses: paambaati/[email protected]
        env:
          CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}

perhaps the default command should be removed?

@paambaati
Copy link
Owner

paambaati commented Oct 1, 2020

@bennypowers The default command needs to be set to an empty string in —

default: 'yarn coverage'

I'd appreciate it if you can send a PR. In the meantime, please specify a coverage command explicitly.

@bennypowers
Copy link
Contributor

יאללה

PR incoming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants