Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libprotobuf-dev and protobuf-compiler to dependencies list #2856

Closed
bogdasar1985 opened this issue Jul 20, 2021 · 3 comments · Fixed by #4056
Closed

Add libprotobuf-dev and protobuf-compiler to dependencies list #2856

bogdasar1985 opened this issue Jul 20, 2021 · 3 comments · Fixed by #4056
Labels
enhancement This topic discusses an improvement to existing compiler code.

Comments

@bogdasar1985
Copy link
Contributor

In my system(Linux Mint 20) CMake output next:

CMake Error at /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
  Could NOT find Protobuf (missing: Protobuf_INCLUDE_DIR) (Required is at
  least version "3.0.0")
Call Stack (most recent call first):
  /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:393 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.16/Modules/FindProtobuf.cmake:624 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:110 (find_package)

It fixed by adding a libprotobuf-dev to dependencies list

@bogdasar1985 bogdasar1985 changed the title Add libprotobuf-dev to dependencies list Add libprotobuf-dev and protobuf-compiler to dependencies list Jul 20, 2021
@mihaibudiu
Copy link
Contributor

Can you try to submit a PR with this change?

@bogdasar1985
Copy link
Contributor Author

@mbudiu-vmw When I said "dependencies list" I meant just the bash script from README.md if you want to test it on CI/CD, then I don't think anything will change

@fruffy
Copy link
Collaborator

fruffy commented Jul 21, 2021

libprotoc-dev and protobuf-compiler are only available starting from Ubuntu 18.04. We still support Ubuntu 16.04, so this does not generalize. This note should be included if we add it to the README. Also, anything we say in the README should ideally be tested by CI.

@fruffy fruffy added the enhancement This topic discusses an improvement to existing compiler code. label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This topic discusses an improvement to existing compiler code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants