Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny Titanium Lockbox ID appears incorrect #45

Closed
Repooc opened this issue Dec 22, 2021 · 2 comments
Closed

Tiny Titanium Lockbox ID appears incorrect #45

Repooc opened this issue Dec 22, 2021 · 2 comments
Assignees
Labels

Comments

@Repooc
Copy link

Repooc commented Dec 22, 2021

While checking the diffs between the lib version I was using to your current one (53), I noticed duplicated id used for Tiny Titanium Lockbox and Iron-Bound Junkbox of 106895, wowhead shows Tiny Titanium Lockbox as 45986. I have not tested this in game, just going by wowhead data and the fact it was duplicate key in the table which didn't look intended

tldr; line 589, key should be 45986 for Tiny Titanium Lockbox if not mistaken

@p3lim
Copy link
Member

p3lim commented Dec 22, 2021

Good catch, thanks for reporting!

@p3lim p3lim closed this as completed in 5e72bb0 Dec 22, 2021
@Repooc
Copy link
Author

Repooc commented Dec 22, 2021

no prob, linter was yelling about it and figured it was an oversite lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants