Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrestoCoverage should honor ExcludeFromCodeCoverage on display #30

Open
dozer75 opened this issue Jan 2, 2020 · 0 comments
Open

PrestoCoverage should honor ExcludeFromCodeCoverage on display #30

dozer75 opened this issue Jan 2, 2020 · 0 comments

Comments

@dozer75
Copy link

dozer75 commented Jan 2, 2020

PrestoCoverage shows code that is marked with the ExcludeFromCodeCoverage as uncovered and thus shows incorrect code coverage result.

image

When running Coverlet with and without ExcludeFromCodeCoverage I can see that the percentage differs; so it handles it in it's calculation; but the result in the coverlet file indicates that it isn't executed (see example below), so I think you'll have to check for the ExcludeFromCodeCoverage on each assembly/class/method and ignore the related code on display.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant