Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(strip-PII): add pre-commit hook to automatically strip PII #5

Open
AnonymousWP opened this issue Sep 20, 2023 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@AnonymousWP
Copy link
Member

No description provided.

@AnonymousWP AnonymousWP added the enhancement New feature or request label Sep 20, 2023
@AnonymousWP AnonymousWP self-assigned this Sep 20, 2023
@adhirajsinghchauhan
Copy link
Member

The main goal here is to avoid PII to be committed to the repo. We don't care about local copies. Sure, upon detecting lines with potential PII, a pre-commit hook can trigger a failure. It will not allow a commit until the user manually removes the offending lines and tries to re-commit (hook will run again, and so on).

Perhaps https://git-scm.com/docs/gitattributes#_filter could be a better idea, as it achieves the goal, while still allowing the user to keep their own copy of a file with PII still in it. Only the repo, and thus anyone who checks out will have a version without PII.

We'll discuss internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants