Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gracefully handle invalid DAGs from the database #106

Open
davepacheco opened this issue Feb 23, 2023 · 1 comment
Open

gracefully handle invalid DAGs from the database #106

davepacheco opened this issue Feb 23, 2023 · 1 comment
Milestone

Comments

@davepacheco
Copy link
Collaborator

See

steno/src/saga_exec.rs

Lines 1072 to 1074 in 0c71fe5

// TODO-robustness we validate that there's exactly one final
// node when we build the DAG, but we should also validate it
// during recovery or else fail more gracefully here. See #32.

It's unclear how high priority this is. This should be impossible because we validate DAGs before we write them to the database. And we only intend to run a given saga with a given Nexus version. However, if we ever did mess this up, a Nexus instance running that saga would wind up in a panic loop, which is pretty bad.

@davepacheco davepacheco added this to the MVP+1 milestone Feb 23, 2023
@davepacheco
Copy link
Collaborator Author

Also covered in #32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant