Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add qorb pooling for native ClickHouse protocol connections #6885

Closed
bnaecker opened this issue Oct 16, 2024 · 1 comment
Closed

Add qorb pooling for native ClickHouse protocol connections #6885

bnaecker opened this issue Oct 16, 2024 · 1 comment
Assignees
@bnaecker
Labels
clickhouse Related to the ClickHouse metrics DBMS

Comments

@bnaecker
Copy link
Collaborator

We added support for the native ClickHouse protocol over TCP in #6584. This tracks adding the qorb-related trait implementations for maintaining a connection pool in the oximeter_db::Client.

A couple of notes:

  • We can use the Ping / Pong packet for the qorb validity check
  • We probably want to completely tear down the TCP connection on serialization failures, since the protocol unfortunately provides no way of recovering one's position in that case (there's no overall message length in a header or anything)
@bnaecker bnaecker added the clickhouse Related to the ClickHouse metrics DBMS label Oct 16, 2024
@bnaecker bnaecker self-assigned this Oct 16, 2024
@bnaecker
Copy link
Collaborator Author

Closed by #6889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnaecker bnaecker

Labels
clickhouse Related to the ClickHouse metrics DBMS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bnaecker