Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static USE_MOCKS is gross and should be removed #4481

Open
andrewjstone opened this issue Nov 9, 2023 · 0 comments
Open

static USE_MOCKS is gross and should be removed #4481

andrewjstone opened this issue Nov 9, 2023 · 0 comments
Labels
cleanup Code cleanliness Sled Agent Related to the Per-Sled Configuration and Management Testing & Analysis Tests & Analyzers

Comments

@andrewjstone
Copy link
Contributor

During the implementation of #4332, I added a static variable that allows selecting between using mocks and not using mocks in tests. This kludge was needed because of feature unification causing the tests in sled-agent to fail when run with all other tests at the top-level. Further details can be found in this comment: #4332 (comment)

We want to eventually remove this disgrace, and the way forward is most likely to refactor the ServiceManager such that it can be tested without mocks in a manner similar to how we restructured StorageManager in #4332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Code cleanliness Sled Agent Related to the Per-Sled Configuration and Management Testing & Analysis Tests & Analyzers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewjstone