tools/destroy_virtual_hardware.sh is missing some new steps

[iliana]

I have an "uninstall the control plane and reinstall it with whatever is in ~/git/omicron" shell script. It is not very good but it reliably keeps me from forgetting a step when I need to set up a control plane. One thing the script does is always run pfexec ./tools/destroy_virtual_hardware.sh after omicron-package uninstall, because external networking does not appear to function for me if I don't destroy and re-create the switch zone. (This is perhaps another issue; should I not need to have to do this?)

Two recent changes have resulted in me making changes to my script that destroy_virtual_hardware.sh doesn't know about:

• allow sled agent to configure a swap device #3571: The sled agent now configures a swap device. I need to identify which device was added as swap and pfexec swap -d it.
• Back /var/fm/fmd with a dataset from the boot M.2 #4212: The sled agent now disables fmd, mounts a new dataset to /var/fm/fmd, and enables fmd again. I need to do the inverse (disable fmd, unmount, enable fmd) to undo that.

I think something should be doing this cleanup but I'm not sure what.

[iliana]

related discussion: #4252

[jordanhendricks]

Sorry for the trouble with the swap device. Does your system not use one by default? Sled agent will not configure one unless there isn't one already.

[iliana]

It didn't use one by default until I finally consistently hit memory limitations while compiling tests yesterday. So perhaps I have solved it for myself this way.