Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit decision to use "bb8" as a connection pool? #4192

Closed
Tracked by #4189
smklein opened this issue Oct 3, 2023 · 0 comments · Fixed by #5876
Closed
Tracked by #4189

Revisit decision to use "bb8" as a connection pool? #4192

smklein opened this issue Oct 3, 2023 · 0 comments · Fixed by #5876
Labels
database Related to database access

Comments

@smklein
Copy link
Collaborator

smklein commented Oct 3, 2023 •
edited
Loading

AFAICT, the decision to use bb8 in Omicron comes from #57 , where it was added with the comment:

Service discovery and connection pooling: I used bb8 here because it was easy. Based on my survey, I think we'll probably want to build our own cueball-like library.

We may want to revisit this decision, weighing the pros and cons of bb8, other connection pools, and building our own.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
database Related to database access
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Qorb integration as connection pool for database oxidecomputer/omicron
1 participant
@smklein