Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to diesel-async? #4188

Open
Tracked by #4189
smklein opened this issue Oct 3, 2023 · 0 comments
Open
Tracked by #4189

Upgrade to diesel-async? #4188

smklein opened this issue Oct 3, 2023 · 0 comments
Labels
database Related to database access nexus Related to nexus

Comments

@smklein
Copy link
Collaborator

smklein commented Oct 3, 2023

We are using https://github.com/oxidecomputer/async-bb8-diesel extensively throughout Nexus, so that we can asynchronously issue diesel operations.

An upgrade to https://crates.io/crates/diesel-async would provide the following benefits:

  1. First-class support. async-bb8-diesel is maintained by us, by swapping between tokio threads, but diesel-async is supported by diesel devs.
  2. Pipelined requests. diesel-async uses tokio_postgres, which supports pipelining: https://docs.rs/tokio-postgres/latest/tokio_postgres/index.html#pipelining
  3. ... speaking of which, tokio_postgres is a rust client library, which might help reduce our reliance on the libpq library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
database Related to database access nexus Related to nexus
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smklein