Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wicket: Add additional cert validation #3398

Closed
jgallagher opened this issue Jun 22, 2023 · 2 comments
Closed

wicket: Add additional cert validation #3398

jgallagher opened this issue Jun 22, 2023 · 2 comments

Comments

@jgallagher
Copy link
Contributor

When uploading cert/key pairs to wicket in preparation for running RSS, we do some basic validation that the key matches the cert, but do not validate:

  • that the cert is valid for the DNS name we expect to have
  • that the cert is the right kind of cert (which might be covered by the previous check?)

Validation functions to support these should be added to CertificateValidator, and wicket should use them once added.

@iliana
Copy link
Contributor

iliana commented Jan 20, 2024

Did #4100 fix this?

@jgallagher
Copy link
Contributor Author

It did! (Well, technically #4086 was the wicket one, and #4100 added the same checks to Nexus.) Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants