Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to tokio 0.3 #60

Closed
mikeyhew opened this issue Nov 10, 2020 · 5 comments · Fixed by #72
Closed

Upgrade to tokio 0.3 #60

mikeyhew opened this issue Nov 10, 2020 · 5 comments · Fixed by #72

Comments

@mikeyhew
Copy link
Contributor

Tokio 0.3 came out in mid-october (https://tokio.rs/blog/2020-10-tokio-0-3), and they're now on 0.3.3, so it seems like it should be stable enough to upgrade to now. I haven't done an upgrade from 0.2 - 0.3, but just speculating, it looks like the main thing to do is use the new feature flag names, and call the .compat() method from tokio-compat-02 to wrap futures from crates that are still on 0.2.

@seanpianka
Copy link

Can you open a PR with the modified Cargo.toml? We can see what fails during compilation then.

@mikeyhew
Copy link
Contributor Author

mikeyhew commented Nov 11, 2020

It looks like I'm a bit early, hyper just updated to tokio 0.3, but it won't be released until hyper 0.14 is out.

@davepacheco
Copy link
Collaborator

davepacheco commented Dec 22, 2020

I think that link was supposed to be to 2319. I also found 2352, in which the hyper authors explain that the plan will be to release 0.14 when tokio 1.0 is out. Given that, I think the most sensible thing for us is to wait for both of those and then update Dropshot to the newer tokio and hyper.

@davepacheco davepacheco linked a pull request Dec 22, 2020 that will close this issue
@mikeyhew
Copy link
Contributor Author

Thanks! I updated the link. That sounds reasonable, I don't know of any tokio 0.3 features that I'm dying to have, so it's not really worth upgrading until the hyper release comes out

@davepacheco
Copy link
Collaborator

It looks like tokio 1.0 and hyper 0.14 were released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants