Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network interfaces #933

Closed
david-crespo opened this issue Jun 13, 2022 · 4 comments · Fixed by #985
Closed

Update network interfaces #933

david-crespo opened this issue Jun 13, 2022 · 4 comments · Fixed by #985
Assignees

Comments

@david-crespo
Copy link
Collaborator

Not sure what the UX is supposed to be like here, but we now have API support:

oxidecomputer/omicron#1186

@benjaminleonard
Copy link
Contributor

benjaminleonard commented Jun 20, 2022

Use the create network interface form as the basis for this – but I do need to document the differences in a pane for a create action versus update and delete.

image

@zephraph
Copy link
Contributor

zephraph commented Jun 28, 2022

@benjaminleonard these options aren't available when editing. We've only got name, description, and primary (which is a boolean that only can be submitted if it's not already selected).

For primary I'm trying to figure out if that should be a checkbox or a radio. I think we need a hint or description or something to explain what's going on. (I'll explain better in the PR)

@bnaecker
Copy link
Contributor

@zephraph If this is for updating more than one interface at a time, the widget would be a radio, since exactly one interface can be the primary. If it's for updating one interface, a checkbox makes more sense. I'd probably recommend disabling it (forcing it to checked) if the interface being edited is the primary. If the interface is a secondary, then a tooltip explaining what it does would be handy indeed.

@zephraph
Copy link
Contributor

It's just for one at a time. I did end up showing it regardless and just having it disabled on the primary. I'll need @benjaminleonard's feedback from the design side just to figure out how to factor in the tooltip, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants