-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate host and target fields on firewall rules #2187
Comments
These are API errors, so there's not that much we can do about them, or at least, if we were going to spend time getting elaborate client-side it would be better spent on the API side so all clients can benefit. |
Actually.... the reason this gets to be an API error is because we fail to catch it in client-side validation in the form. So we can probably improve that. |
Thinking more about this, the validation problem is lessened if we're using comboboxes to pick the VPC, subnet, or instance names (#2065), but because we will not be constraining those fields to values that already exist (the lists are just there to help), we will still have the validation problem. |
If we validate these on the client, they will not hit the API and the user will not have to figure out what these API error messages mean. Note that validating host and target depends on the type selected in the dropdown. The validate function will have to look at the selected type to decide which validation to run. Ideally, changing the type will re-run validation on the value field (I don't think it will work this way by default).
The text was updated successfully, but these errors were encountered: