Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate host and target fields on firewall rules #2187

Open
charliepark opened this issue Apr 23, 2024 · 3 comments
Open

Validate host and target fields on firewall rules #2187

charliepark opened this issue Apr 23, 2024 · 3 comments

Comments

@charliepark
Copy link
Contributor

charliepark commented Apr 23, 2024

image

image

If we validate these on the client, they will not hit the API and the user will not have to figure out what these API error messages mean. Note that validating host and target depends on the type selected in the dropdown. The validate function will have to look at the selected type to decide which validation to run. Ideally, changing the type will re-run validation on the value field (I don't think it will work this way by default).

@david-crespo
Copy link
Collaborator

These are API errors, so there's not that much we can do about them, or at least, if we were going to spend time getting elaborate client-side it would be better spent on the API side so all clients can benefit.

@david-crespo
Copy link
Collaborator

Actually.... the reason this gets to be an API error is because we fail to catch it in client-side validation in the form. So we can probably improve that.

@david-crespo david-crespo modified the milestone: 8 Apr 23, 2024
@david-crespo
Copy link
Collaborator

david-crespo commented Apr 24, 2024

Thinking more about this, the validation problem is lessened if we're using comboboxes to pick the VPC, subnet, or instance names (#2065), but because we will not be constraining those fields to values that already exist (the lists are just there to help), we will still have the validation problem.

@david-crespo david-crespo changed the title Improve copy on form validation errors Validate host and target fields on firewall rules Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants