Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try .git-blame-ignore-revs #1972

Closed
david-crespo opened this issue Feb 23, 2024 · 1 comment
Closed

Try .git-blame-ignore-revs #1972

david-crespo opened this issue Feb 23, 2024 · 1 comment
Labels

Comments

@david-crespo
Copy link
Collaborator

It seems this works on GitHub now. If we have PRs like #1971 where all we do is shuffle around files and imports, that stuff is useless in the blame view, so we can filter it out.

https://github.com/orgs/community/discussions/5033#discussioncomment-2318478

@david-crespo
Copy link
Collaborator Author

david-crespo commented Feb 23, 2024

Tried in 1745a75 and reverted in e2e56d8. It did work to filter the git blame, but I realized that if there are any changes in the commit that you don't want to hide the blame for, you are in trouble. For example, with the most recent commit ignored, you can't tell from the blame when we added the ~/* alias in the tsconfig.

https://github.com/oxidecomputer/console/blame/e2e56d879ca14a5b22080aacaefdea71e365e618/tsconfig.json#L15

So if we want to use this feature in the future (and it is very cool) we need to make sure that the commits in question don't have any lines we want to be able to blame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant