Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing enter in firewall rule "subforms" should not submit full form #1919

Closed
david-crespo opened this issue Jan 29, 2024 · 2 comments · Fixed by #1928
Closed

Pressing enter in firewall rule "subforms" should not submit full form #1919

david-crespo opened this issue Jan 29, 2024 · 2 comments · Fixed by #1928
Assignees
Milestone

Comments

@david-crespo
Copy link
Collaborator

I instinctively press enter when trying to add a target or host, expecting it to be equivalent to clicking the add button, but instead it submits the whole form, which is very frustrating. This is especially bad because it can be hard to tell what you did and didn't change.

image
@charliepark
Copy link
Contributor

I'm having trouble replicating this issue, on either Firefox or Chrome. I think I'm following the described flow using the enter key as often as I can (highlight Host type input and hit enter to get dropdown; arrow key down/up to select one; hit enter to select; tab to next field; type in a string; tab to Add host filter button; hit enter → it adds a new host filter line; focus is still on button with now-emptied form, and I can tab from there onto the newly-created host line). Happy to try again if I'm missing a step in the bug replication.

@david-crespo
Copy link
Collaborator Author

I'm hitting enter while still in the value field, not tabbing to the button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants