From c2406cdda264f7abe99f1f93883c51faef5b5b26 Mon Sep 17 00:00:00 2001 From: Charlie Park Date: Wed, 18 Dec 2024 15:48:19 -0800 Subject: [PATCH] remove unrelated EmptyCell change --- app/table/cells/InstanceLinkCell.tsx | 4 ++-- test/e2e/disks.e2e.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/table/cells/InstanceLinkCell.tsx b/app/table/cells/InstanceLinkCell.tsx index ed706e736..b2fbe019c 100644 --- a/app/table/cells/InstanceLinkCell.tsx +++ b/app/table/cells/InstanceLinkCell.tsx @@ -11,7 +11,7 @@ import { useApiQuery } from '@oxide/api' import { useProjectSelector } from '~/hooks/use-params' import { pb } from '~/util/path-builder' -import { EmptyCell, SkeletonCell } from './EmptyCell' +import { SkeletonCell } from './EmptyCell' import { LinkCell } from './LinkCell' export const InstanceLinkCell = ({ instanceId }: { instanceId?: string }) => { @@ -23,7 +23,7 @@ export const InstanceLinkCell = ({ instanceId }: { instanceId?: string }) => { ) // has to be after the hooks because hooks can't be executed conditionally - if (!instanceId) return + if (!instanceId) return null if (!instance) return return ( diff --git a/test/e2e/disks.e2e.ts b/test/e2e/disks.e2e.ts index 85fd6d35c..e735f7dad 100644 --- a/test/e2e/disks.e2e.ts +++ b/test/e2e/disks.e2e.ts @@ -29,7 +29,7 @@ test('List disks and snapshot', async ({ page }) => { state: 'attached', }) await expectRowVisible(table, { - 'Attached to': '—', + 'Attached to': '', name: 'disk-3', size: '6 GiB', state: 'detached',