From 01d61588e2229b25dba36b2bc3ebe7a59d53b297 Mon Sep 17 00:00:00 2001
From: David Crespo <david.crespo@oxidecomputer.com>
Date: Wed, 3 Jul 2024 14:31:54 -0500
Subject: [PATCH] remove ExternalLink component used in one spot

---
 app/components/DocsPopover.tsx  | 10 +++++-----
 app/components/ExternalLink.tsx | 27 ---------------------------
 2 files changed, 5 insertions(+), 32 deletions(-)
 delete mode 100644 app/components/ExternalLink.tsx

diff --git a/app/components/DocsPopover.tsx b/app/components/DocsPopover.tsx
index 7f08da88da..154ce2be0c 100644
--- a/app/components/DocsPopover.tsx
+++ b/app/components/DocsPopover.tsx
@@ -13,17 +13,17 @@ import { OpenLink12Icon, Question12Icon } from '@oxide/design-system/icons/react
 
 import { buttonStyle } from '~/ui/lib/Button'
 
-import { ExternalLink } from './ExternalLink'
-
 type DocsPopoverLinkProps = {
   href: string
   linkText: string
 }
 
 export const DocsPopoverLink = ({ href, linkText }: DocsPopoverLinkProps) => (
-  <ExternalLink
+  <a
     href={href}
-    className="group block px-4 no-underline children:last:border-0"
+    className="group block px-4 children:last:border-0"
+    target="_blank"
+    rel="noreferrer"
   >
     <div className="mx-2 border-b py-1.5 border-secondary">
       <div className="relative -ml-2 inline-block rounded py-1 pl-2 pr-7 text-sans-md !text-default group-hover:bg-tertiary">
@@ -31,7 +31,7 @@ export const DocsPopoverLink = ({ href, linkText }: DocsPopoverLinkProps) => (
         <OpenLink12Icon className="absolute top-1.5 ml-2 translate-y-[1px] text-tertiary" />
       </div>
     </div>
-  </ExternalLink>
+  </a>
 )
 
 type DocsPopoverProps = {
diff --git a/app/components/ExternalLink.tsx b/app/components/ExternalLink.tsx
deleted file mode 100644
index c12a93f5f3..0000000000
--- a/app/components/ExternalLink.tsx
+++ /dev/null
@@ -1,27 +0,0 @@
-/*
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, you can obtain one at https://mozilla.org/MPL/2.0/.
- *
- * Copyright Oxide Computer Company
- */
-import cn from 'classnames'
-
-type ExternalLinkProps = {
-  href: string
-  className?: string
-  children: React.ReactNode
-}
-
-export function ExternalLink({ href, className, children }: ExternalLinkProps) {
-  return (
-    <a
-      href={href}
-      className={cn('underline text-accent-secondary hover:text-accent', className)}
-      target="_blank"
-      rel="noreferrer"
-    >
-      {children}
-    </a>
-  )
-}