Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use custom canonicalize impl to avoid usless syscall #220

Merged

Conversation

Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn commented Jul 9, 2024

Reduce one redundant fs::symlink_metadata system call.

Copy link
Member Author

Brooooooklyn commented Jul 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (1013c5e) to head (6f70506).

Additional details and impacted files
@@                         Coverage Diff                          @@
##           07-09-bench_add_symlink_fixtures     #220      +/-   ##
====================================================================
+ Coverage                             96.92%   96.95%   +0.03%     
====================================================================
  Files                                    11       11              
  Lines                                  2306     2298       -8     
====================================================================
- Hits                                   2235     2228       -7     
+ Misses                                   71       70       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Brooooooklyn Brooooooklyn force-pushed the 07-09-bench_add_symlink_fixtures branch from 0034181 to 4a78c0d Compare July 9, 2024 14:38
@Brooooooklyn Brooooooklyn force-pushed the 07-09-perf_use_custom_canonicalize_impl_to_avoid_heavy_syscall branch from 7592c31 to bf064b6 Compare July 9, 2024 14:38
Copy link

codspeed-hq bot commented Jul 9, 2024

CodSpeed Performance Report

Merging #220 will not alter performance

Comparing 07-09-perf_use_custom_canonicalize_impl_to_avoid_heavy_syscall (a5fc16f) with main (e29975d)

Summary

✅ 3 untouched benchmarks

@Brooooooklyn Brooooooklyn force-pushed the 07-09-bench_add_symlink_fixtures branch from 4a78c0d to a94a984 Compare July 9, 2024 14:41
@Brooooooklyn Brooooooklyn force-pushed the 07-09-perf_use_custom_canonicalize_impl_to_avoid_heavy_syscall branch 3 times, most recently from 1a6a707 to 27f03c6 Compare July 9, 2024 14:56
@Brooooooklyn Brooooooklyn changed the title perf: use custom canonicalize impl to avoid heavy syscall perf: use custom canonicalize impl to avoid usless syscall Jul 9, 2024
@Brooooooklyn Brooooooklyn force-pushed the 07-09-bench_add_symlink_fixtures branch from a94a984 to f77fa0b Compare July 10, 2024 05:54
@Brooooooklyn Brooooooklyn force-pushed the 07-09-perf_use_custom_canonicalize_impl_to_avoid_heavy_syscall branch from 27f03c6 to e92290c Compare July 10, 2024 05:54
@Brooooooklyn Brooooooklyn force-pushed the 07-09-bench_add_symlink_fixtures branch from f77fa0b to 8013161 Compare July 10, 2024 05:54
@Brooooooklyn Brooooooklyn force-pushed the 07-09-perf_use_custom_canonicalize_impl_to_avoid_heavy_syscall branch 2 times, most recently from 0a101f2 to 697cc7f Compare July 10, 2024 06:11
@Brooooooklyn Brooooooklyn force-pushed the 07-09-bench_add_symlink_fixtures branch from 8013161 to 1013c5e Compare July 10, 2024 06:26
@Brooooooklyn Brooooooklyn force-pushed the 07-09-perf_use_custom_canonicalize_impl_to_avoid_heavy_syscall branch from 697cc7f to 6f70506 Compare July 10, 2024 06:26
@Boshen
Copy link
Member

Boshen commented Jul 10, 2024

Request me a review once you're done.

@Brooooooklyn Brooooooklyn requested a review from Boshen July 10, 2024 07:30
src/file_system.rs Show resolved Hide resolved
src/file_system.rs Show resolved Hide resolved
src/file_system.rs Show resolved Hide resolved
Copy link
Member

Boshen commented Jul 10, 2024

Merge activity

  • Jul 10, 10:33 AM EDT: @Boshen started a stack merge that includes this pull request via Graphite.
  • Jul 10, 10:35 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 10, 10:37 AM EDT: @Boshen merged this pull request with Graphite.

@Boshen Boshen changed the base branch from 07-09-bench_add_symlink_fixtures to graphite-base/220 July 10, 2024 14:33
@Boshen Boshen changed the base branch from graphite-base/220 to main July 10, 2024 14:34
@Boshen Boshen force-pushed the 07-09-perf_use_custom_canonicalize_impl_to_avoid_heavy_syscall branch from 6f70506 to a5fc16f Compare July 10, 2024 14:34
@Boshen Boshen merged commit b6eeab6 into main Jul 10, 2024
19 checks passed
@Boshen Boshen deleted the 07-09-perf_use_custom_canonicalize_impl_to_avoid_heavy_syscall branch July 10, 2024 14:37
Brooooooklyn added a commit that referenced this pull request Jul 10, 2024
Boshen pushed a commit that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants