Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: fix failed publish caused by cyclic dev dependencies " #4419

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 23, 2024

Reverts #4416

This trick doesn't work for crates that have circular dependencies on each other that all need to be published!

Copy link

graphite-app bot commented Jul 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Dunqing Dunqing merged commit 25dab7b into main Jul 23, 2024
13 checks passed
@Dunqing Dunqing deleted the revert-4416-fix/cycle-dev-dependency-failed-ci branch July 23, 2024 07:56
DonIsaac pushed a commit that referenced this pull request Jul 23, 2024
…#4419)

Reverts #4416

This trick doesn't work for crates that have circular dependencies on
each other that all need to be published!
DonIsaac pushed a commit that referenced this pull request Jul 24, 2024
…#4419)

Reverts #4416

This trick doesn't work for crates that have circular dependencies on
each other that all need to be published!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant