Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider better focus handling when showing a dialog #89

Open
sivakusayan opened this issue Sep 25, 2023 · 2 comments · May be fixed by #91
Open

Consider better focus handling when showing a dialog #89

sivakusayan opened this issue Sep 25, 2023 · 2 comments · May be fixed by #91

Comments

@sivakusayan
Copy link
Contributor

In a Clojure exercise, opening the "Settings" dialog should move focus into the dialog and prevent focus from moving into the blacked-out background of the dialog. Ditto for the dialog that appears when you successfully complete an exercise. This will make keyboard-only workflows less tedious.

Dialog (Modal) - ARIA Authoring Practices Guide

I don't mind taking a stab at this if you're okay with this.
@borkdude
Copy link
Collaborator

Sounds good to me, what about you @oxalorg ?

@oxalorg
Copy link
Owner

oxalorg commented Sep 26, 2023

@sivakusayan Thanks that would be much appreciated!

@sivakusayan sivakusayan linked a pull request Oct 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use dialog element to manage focus inside modals sivakusayan/4ever-clojure
3 participants
@borkdude @oxalorg @sivakusayan