Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing jail followup #1 #7379

Merged
merged 5 commits into from
Aug 1, 2022
Merged

Sharing jail followup #1 #7379

merged 5 commits into from
Aug 1, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Aug 1, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Aug 1, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from kulmann August 1, 2022 08:24
@AlexAndBear AlexAndBear mentioned this pull request Aug 1, 2022
Closed
7 tasks
@AlexAndBear AlexAndBear marked this pull request as ready for review August 1, 2022 08:25
@AlexAndBear AlexAndBear marked this pull request as draft August 1, 2022 08:40
@AlexAndBear AlexAndBear removed the request for review from kulmann August 1, 2022 08:40
@AlexAndBear AlexAndBear changed the title Fix wrong path Sharing jail followup #1 Aug 1, 2022
@AlexAndBear AlexAndBear marked this pull request as ready for review August 1, 2022 09:34
@AlexAndBear AlexAndBear requested a review from kulmann August 1, 2022 09:34
@AlexAndBear AlexAndBear requested a review from kulmann August 1, 2022 09:52
kulmann
kulmann approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 501005c into master Aug 1, 2022
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
@kulmann kulmann deleted the issues/6899#1 branch September 5, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAndBear @kulmann