update all uikit tooltips to use v-oc-tooltip #5055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalwengerter
requested changes
Apr 30, 2021
kulmann
requested changes
May 5, 2021
| @@ -61,9 +61,9 @@ | |||
| <div v-if="$_reshareInformation"> | |||
| <oc-tag | |||
| :id="$_resharerToggleId" | |||
| v-oc-tooltip="$gettext('Show resharer details')" | |||
There was a problem hiding this comment.
Does this tag need a tooltip at all? Usability wise?
There was a problem hiding this comment.
Wouldn't say so. There's tags that are links and there I find tooltips helpful, if it's "just" a small hint I would omit them
pascalwengerter
force-pushed
the
a11y-tooltips
branch
from
1c43cf0 to
62e1f4b
Compare
pascalwengerter
previously approved these changes
May 7, 2021
pascalwengerter
dismissed
their stale review
Took over this PR myself so can't review
💥 Acceptance tests webUINotificationBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15341/
|
💥 Acceptance tests MarkdownEditor failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15341/
|
💥 Acceptance tests TrashbinDelete failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15341/
|
💥 Acceptance tests TrashbinFilesFolders failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15341/
|
💥 Acceptance tests SharingPublicDifferentRoles failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15341/
|
💥 Acceptance tests SharingPublicExpire failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15341/
|
pascalwengerter
force-pushed
the
a11y-swarming
branch
from
8a2284f to
9c69cd3
Compare
pascalwengerter
force-pushed
the
a11y-tooltips
branch
from
62e1f4b to
66804d2
Compare
pascalwengerter
force-pushed
the
a11y-swarming
branch
from
a2abe5e to
d927513
Compare
pascalwengerter
force-pushed
the
a11y-tooltips
branch
from
66804d2 to
6802202
Compare
kulmann
requested changes
May 25, 2021
| @@ -7,7 +7,7 @@ | |||
| class="oc-topbar-menu-burger" | |||
| :aria-label="applicationSwitcherLabel" | |||
| > | |||
| <oc-icon :uk-tooltip="applicationSwitcherLabel" name="apps" class="uk-flex" /> | |||
| <oc-icon v-oc-tooltip="applicationSwitcherLabel" name="apps" class="uk-flex" /> | |||
There was a problem hiding this comment.
Tooltip could be moved to the oc-button
| @@ -182,6 +183,8 @@ export default { | |||
| } | |||
| }, | |||
| canUpload() { | |||
| // return this.currentFolder.permissions.indexOf('C') >= 0 | |||
There was a problem hiding this comment.
Comment (following line as well) can be removed
pascalwengerter
force-pushed
the
a11y-tooltips
branch
from
6802202 to
b7ad624
Compare
This was referenced Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update all tooltips to use oc-tooltips which will land in the next version of ods (6.4.0)
Related Issue
Motivation and Context
uitooltip is not accessible, a11y audit requires this.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: