Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y improvements for meta attributes #4811

Merged
merged 1 commit into from
Mar 16, 2021
Merged

A11y improvements for meta attributes #4811

merged 1 commit into from
Mar 16, 2021

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 16, 2021 •
edited
Loading

Description

  • For a11y the html language attribute will be set dynamically <html lang="xx"/>
  • For a11y the title will be set automatticaly following the schema : sub item (e.G file) - route (e.g All Files) - general name (e.g ownCloud)

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Mar 16, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from JammingBen March 16, 2021 11:20
@CLAassistant
Copy link

CLAassistant commented Mar 16, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AlexAndBear AlexAndBear changed the title Add lang to html attribute and title to meta A11y improvements for meta attributes Mar 16, 2021
@AlexAndBear AlexAndBear marked this pull request as ready for review March 16, 2021 11:34
@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Mar 16, 2021
Closed
@JammingBen JammingBen mentioned this pull request Mar 16, 2021
Merged
9 tasks
@AlexAndBear AlexAndBear force-pushed the enhanche-meta-attributs branch from dee5c6b to e66d544 Compare March 16, 2021 12:18
pascalwengerter
pascalwengerter approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could mention the issues resolved here (#4342, #4338) in the changelog, but otherwise looks fine 🔥

kulmann
kulmann requested changes Mar 16, 2021
View reviewed changes
packages/web-runtime/src/App.vue Outdated Show resolved Hide resolved
@AlexAndBear AlexAndBear force-pushed the enhanche-meta-attributs branch from e66d544 to ba2c248 Compare March 16, 2021 13:46
@AlexAndBear AlexAndBear requested a review from kulmann March 16, 2021 13:46
kulmann
kulmann approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😍
Could you rebase please? Might be that the failing test pipeline will be fixed by that.

@AlexAndBear
Copy link
Contributor Author

already up to date ....

@kulmann
Copy link
Member

kulmann commented Mar 16, 2021

already up to date ....

ok, thanks. Then we need to have a look at the failing test.

@AlexAndBear
Copy link
Contributor Author

@kulmann restarted ci - green now 🚀

@kulmann kulmann merged commit ef53be6 into master Mar 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the enhanche-meta-attributs branch March 16, 2021 17:38
@pascalwengerter pascalwengerter mentioned this pull request Jun 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexAndBear @CLAassistant @kulmann @pascalwengerter