Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Overwrite file uploads, remove redundant scenarios #2471

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Test: Overwrite file uploads, remove redundant scenarios #2471

merged 2 commits into from
Nov 22, 2019

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Nov 15, 2019 •
edited
Loading

Description

This PR adds test for overwriting file uploads and removes redundant scenarios.

Related Issue

Motivation and Context

#2400 (comment)

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@skshetry skshetry self-assigned this Nov 15, 2019
dpakach
dpakach previously approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ownclouders
Copy link
Contributor

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6478/

20191115-073533-812.png
20191115-073606-353.png

@skshetry skshetry changed the title Test: Overwrite file uploads, remove redundant scenarioss Test: Overwrite file uploads, remove redundant scenarios Nov 15, 2019
@ownclouders
Copy link
Contributor

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6500/

20191118-042833-405.png
20191118-042906-964.png

@skshetry skshetry force-pushed the rm-redundant-impl-overwrite-uploads branch from 9c454ff to 1680eb5 Compare November 19, 2019 09:50
@skshetry skshetry dismissed dpakach’s stale review November 19, 2019 09:50

Added a hack. Please review again

@skshetry skshetry force-pushed the rm-redundant-impl-overwrite-uploads branch from 1680eb5 to 5bc7a4e Compare November 21, 2019 08:39
@skshetry skshetry requested a review from dpakach November 21, 2019 09:17
@phil-davis phil-davis merged commit edeab70 into master Nov 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the rm-redundant-impl-overwrite-uploads branch November 22, 2019 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@individual-it individual-it Awaiting requested review from individual-it

@dpakach dpakach Awaiting requested review from dpakach

Assignees

@skshetry skshetry

Labels
QA:team Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skshetry @ownclouders @phil-davis @dpakach