Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Files drop without password #2415

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Test Files drop without password #2415

merged 1 commit into from
Nov 13, 2019

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Nov 8, 2019 •
edited
Loading

Description

Adds a test for public link files and folder uploads without password

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally and CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@PVince81 PVince81 changed the title Files drop without password Test Files drop without password Nov 8, 2019
@skshetry skshetry mentioned this pull request Nov 12, 2019
Merged
10 tasks
@skshetry skshetry force-pushed the files-drop-without-password branch from 91fb6b5 to f911ada Compare November 13, 2019 03:37
@skshetry skshetry self-assigned this Nov 13, 2019
@skshetry skshetry marked this pull request as ready for review November 13, 2019 03:39
@owncloud owncloud deleted a comment from ownclouders Nov 13, 2019
dpakach
dpakach approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dpakach dpakach merged commit 3c7318e into master Nov 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the files-drop-without-password branch November 13, 2019 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpakach dpakach dpakach approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@skshetry skshetry

Labels
QA:team Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skshetry @dpakach