Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test public link uploads with/without password #2400

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Test public link uploads with/without password #2400

merged 2 commits into from
Nov 12, 2019

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Nov 7, 2019 •
edited
Loading

Description

This adds tests for files and folder uploads in root and inside subdirectory, with a password, and without a password. This also fixes bug when a folder is uploaded via a public link when the password is set. (ref: #2402 ).

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally and CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@skshetry skshetry self-assigned this Nov 7, 2019
@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6220/

20191107-062728-348.png
20191107-062728-777.png
20191107-062729-210.png
20191107-062729-521.png
20191107-062729-741.png
20191107-062729-941.png
20191107-062730-191.png
20191107-062730-559.png
20191107-062730-902.png
20191107-062731-123.png
20191107-062830-813.png
20191107-062831-190.png
20191107-062831-684.png
20191107-062832-126.png
20191107-062832-662.png
20191107-062832-931.png
20191107-062833-317.png
20191107-062833-597.png
20191107-062833-856.png
20191107-062834-149.png
20191107-063119-795.png
20191107-063154-502.png
20191107-063229-141.png
20191107-063305-880.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6220/

20191107-062238-398.png
20191107-062238-814.png
20191107-062239-290.png
20191107-062239-586.png
20191107-062239-986.png
20191107-062749-775.png
20191107-062750-286.png
20191107-062750-710.png
20191107-062751-233.png
20191107-062751-576.png
20191107-062751-965.png
20191107-062752-477.png
20191107-062752-804.png
20191107-062753-111.png
20191107-062753-482.png
20191107-062903-700.png
20191107-062904-143.png
20191107-062904-460.png
20191107-062904-868.png
20191107-062905-307.png
20191107-062905-726.png
20191107-062906-007.png
20191107-062906-410.png
20191107-062906-688.png
20191107-062906-938.png
20191107-063001-172.png
20191107-063001-820.png
20191107-063002-353.png
20191107-063002-741.png
20191107-063003-038.png
20191107-063003-418.png
20191107-063003-863.png
20191107-063004-241.png
20191107-063004-484.png
20191107-063004-707.png
20191107-063004-942.png
20191107-063005-168.png
20191107-063005-399.png
20191107-063005-629.png
20191107-063006-002.png
20191107-063058-326.png
20191107-063058-611.png
20191107-063059-213.png
20191107-063059-676.png
20191107-063100-261.png
20191107-063100-574.png
20191107-063100-891.png
20191107-063101-424.png
20191107-063101-765.png
20191107-063102-061.png
20191107-063313-335.png
20191107-063313-585.png
20191107-063313-845.png
20191107-063314-109.png
20191107-063314-545.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Upload failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6220/

20191107-062252-919.png
20191107-062355-827.png
20191107-062629-521.png
20191107-062733-248.png
20191107-062838-124.png
20191107-062942-556.png
20191107-063046-323.png
20191107-063149-712.png
20191107-063309-808.png
20191107-063409-710.png
20191107-063510-730.png
20191107-063632-519.png
20191107-063734-352.png
20191107-063841-249.png
20191107-063948-527.png
20191107-064053-539.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6220/

20191107-064704-145.png
20191107-064801-732.png
20191107-064859-076.png
20191107-064957-183.png
20191107-065053-761.png
20191107-065150-843.png
20191107-065247-832.png
20191107-065345-605.png
20191107-065444-356.png
20191107-065543-164.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6220/

20191107-065200-334.png
20191107-065301-121.png
20191107-065401-735.png
20191107-065502-774.png
20191107-065623-414.png
20191107-065725-659.png
20191107-065828-774.png
20191107-065932-327.png
20191107-070034-610.png
20191107-070137-805.png

@skshetry skshetry mentioned this pull request Nov 7, 2019
Closed
@ownclouders
Copy link
Contributor

💥 Acceptance tests Upload failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6232/

20191107-120054-429.png
20191107-120216-298.png
20191107-120514-549.png
20191107-120639-293.png
20191107-120803-955.png
20191107-120927-439.png
20191107-121049-915.png
20191107-121216-476.png
20191107-121340-677.png
20191107-121504-658.png
20191107-121631-545.png
20191107-121757-791.png
20191107-121921-199.png
20191107-122043-725.png
20191107-122209-871.png
20191107-122337-236.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6232/

20191107-122449-939.png
20191107-122609-020.png
20191107-122728-447.png
20191107-122848-518.png
20191107-123007-653.png
20191107-123126-997.png
20191107-123246-980.png
20191107-123406-346.png
20191107-123527-354.png
20191107-123648-621.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6232/

20191107-121823-529.png
20191107-121823-764.png
20191107-121824-035.png
20191107-121824-273.png
20191107-121824-426.png
20191107-122642-893.png
20191107-122805-434.png
20191107-122934-701.png
20191107-123056-500.png
20191107-123217-837.png
20191107-123339-252.png
20191107-123502-267.png
20191107-123625-150.png
20191107-123756-495.png
20191107-123923-494.png

@skshetry skshetry force-pushed the public-link-uploads branch 2 times, most recently from 6f1a49d to 63f42d2 Compare November 8, 2019 03:57
@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6243/

20191108-041409-279.png
20191108-041409-493.png
20191108-041409-692.png
20191108-041409-909.png
20191108-041410-160.png
20191108-041410-357.png
20191108-041410-561.png
20191108-041410-760.png
20191108-041411-056.png
20191108-041411-285.png
20191108-041411-494.png
20191108-041411-703.png
20191108-041411-921.png
20191108-041412-158.png
20191108-041412-358.png
20191108-041613-309.png
20191108-041643-466.png
20191108-041714-356.png
20191108-041744-839.png

@skshetry
Copy link
Member Author

skshetry commented Nov 8, 2019 •
edited
Loading

The usual test and folder upload in the public link with password set failed. I'll push a fix.

@ownclouders
Copy link
Contributor

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6247/

20191108-061536-534.png
20191108-061536-904.png
20191108-061537-197.png
20191108-061537-765.png
20191108-061538-074.png
20191108-061538-389.png
20191108-061538-823.png
20191108-061539-335.png
20191108-061539-750.png
20191108-061540-226.png
20191108-061540-503.png
20191108-061540-759.png
20191108-061541-234.png
20191108-061541-501.png
20191108-061541-776.png
20191108-061647-473.png
20191108-061647-763.png
20191108-061648-230.png
20191108-061648-753.png
20191108-061649-037.png

skshetry
skshetry commented Nov 8, 2019
View reviewed changes
tests/acceptance/features/webUISharingPublic/shareByPublicLink.feature
Then file "new-lorem.txt" should be listed on the webUI
And as "user1" file "simple-folder/new-lorem.txt" should exist

Scenario: creating a public link with "Editor" role makes it possible to upload a file inside a subdirectory
Copy link
Member Author

@skshetry skshetry Nov 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been the following, but, I just noticed. I already have a PR in the works that fixes this.
It'll be fixed in the "other" PR. Or, if anything needs to be fixed, I'll do this in this same PR.

Suggested change
Scenario: creating a public link with "Editor" role makes it possible to upload a file inside a subdirectory
Scenario: creating a public link with "Editor" role makes it possible to upload a file inside a subdirectory with password set

@skshetry
Copy link
Member Author

skshetry commented Nov 8, 2019 •
edited
Loading

Only the usual test failed, so, the fix works.

@haribhandari07
Copy link
Contributor

LGTM

@phil-davis phil-davis added Status:Needs-release and removed Status:Needs-Review Needs review from a maintainer labels Nov 8, 2019
@phil-davis
Copy link
Contributor

I restarted drone just now.

@ownclouders
Copy link
Contributor

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6270/

20191108-121626-432.png
20191108-121626-883.png
20191108-121627-313.png
20191108-121627-683.png
20191108-121628-118.png
20191108-121628-559.png
20191108-121628-982.png
20191108-121629-382.png
20191108-121629-671.png
20191108-121629-936.png
20191108-121630-296.png
20191108-121630-900.png
20191108-121631-153.png
20191108-121631-376.png
20191108-121631-643.png
20191108-121742-613.png
20191108-121743-011.png
20191108-121743-429.png
20191108-121743-775.png
20191108-121744-077.png
20191108-121744-489.png
20191108-121744-899.png
20191108-121745-261.png
20191108-121745-726.png
20191108-121746-118.png
20191108-121746-381.png
20191108-121746-771.png
20191108-121747-041.png
20191108-121747-311.png
20191108-121747-571.png
20191108-122252-208.png
20191108-122252-445.png
20191108-122252-926.png
20191108-122253-211.png
20191108-122253-547.png

@skshetry skshetry requested a review from PVince81 November 11, 2019 07:54
LukasHirt
LukasHirt requested changes Nov 11, 2019
View reviewed changes
apps/files/src/mixins.js Show resolved Hide resolved
@skshetry skshetry mentioned this pull request Nov 12, 2019
Merged
10 tasks
@skshetry skshetry force-pushed the public-link-uploads branch from b40e2b9 to fe76e7c Compare November 12, 2019 08:58
@skshetry skshetry merged commit fd30a78 into master Nov 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the public-link-uploads branch November 12, 2019 14:01
@PVince81
Copy link
Contributor

@skshetry can you evaluate these public link upload scenarios and delete them if already implemented ? https://github.com/owncloud/phoenix/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L139

@skshetry skshetry mentioned this pull request Nov 15, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haribhandari07 haribhandari07 haribhandari07 approved these changes

@LukasHirt LukasHirt LukasHirt approved these changes

@phil-davis phil-davis phil-davis approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@dpakach dpakach Awaiting requested review from dpakach

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@skshetry skshetry

Labels
QA:team Status:Needs-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@skshetry @ownclouders @haribhandari07 @phil-davis @PVince81 @dpakach @LukasHirt