Folder upload with mounted volume #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
force-pushed
the
poc-selenium-mount
branch
from
fcf5457 to
83cfc1e
Compare
skshetry
changed the title
💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6136/
|
dpakach
reviewed
Nov 5, 2019
skshetry
added
Status:Needs-Review
phil-davis
approved these changes
Nov 5, 2019
phil-davis
added
Status:Needs-release
and removed
Status:Needs-Review
skshetry
force-pushed
the
poc-selenium-mount
branch
from
fc3b46a to
7b3a82a
Compare
skshetry
force-pushed
the
poc-selenium-mount
branch
from
7b3a82a to
b359612
Compare
dpakach
approved these changes
Nov 5, 2019
|
Let's wait until tomorrow morning to merge this, so that we are online if others need help with how to run upload tests. |
|
@phil-davis, I left a message in the chat, and also have adjusted documentation in the README. So, it should be fine to merge this. |
|
Merging - it is after office hours in Europe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2203 added tests for uploading files. #2222 has more requirements related to folder upload, which is not possible using the
sessionfolder upload mechanism. This PR mountstests/acceptance/filesForUploadfolder from this repo to/home/seluser/uploadsinside selenium, which provides us access to those files in the browser during uploads.This might need changes to how we run acceptance tests. This PR proposes a
LOCAL_UPLOAD_DIRenvironment variable.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: