Release 4.2.0

[kulmann]

Release checklist

• prepare release rc: @kulmann
  • create a branch release-4.2.0 @kulmann
  • update the version in packages/web-integration-oc10/appinfo/info.xml @kulmann
  • update the version in package.json @kulmann
  • update the version in sonar-project.properties @kulmann
  • move changelog/unreleased/* to changelog/VERSION_YYYY-MM-DD @kulmann
  • update the ocis commit id in .drone.env to the most recent one from ocis master (i.e. let the web UI tests run on most recent ocis master) @kulmann
  • commit, push and create draft PR for this branch @kulmann
• create pre release tag v4.2.0-rc1 from the release branch @pascalwengerter
• smoke test
  • against oCIS @ScharfViktor
  • against oc10 standalone @LukasHirt
  • against oc10 as app installation @kulmann
• if needed, fix issues or write down known issues
• update YYYY-MM-DD to current date in changelog/VERSION_YYYY-MM-DD @pascalwengerter
• Make sure translations are up to date
• repeat above steps if a new rc is needed
• Run translations sync job once again
• go to the releases section and click Draft a new Release. Use v4.2.0 as a tag (the v prefix is important) and 4.2.0 as name and publish it
• ping in internal #btr channel to create a signed marketplace release
• merge release branch back to master (CI must be green)

[kulmann]

Issues from explorative smoke testing:

• being in a folder, right sidebar, people (or any other subpanel), navigate back to root via breadcrumbs => right sidebar is empty (@kulmann on it)
• fix h-tags in right sidebar (also some more minor a11y offenses detected, @pascalwengerter on it)

followup after release:

• refactor shares tree into it's own store module and use it to make the sharing related data props in FileDetails computed props (which would be far less error prone).
• sharing related info in FileDetails (both the icons at the top and the table rows at the bottom) show sharing info for incoming and outgoing shares. We need to be more precise there, depending on whether the user is on the All files, Shared with me or Shared with others/via link page and filter out incoming or outgoing shares respectively.

[LukasHirt]

Smoke test standalone against oc10

• ✔️ as gunter - upload 2000 files to a folder

  • progress bar is not sticky
  • expanding the upload progress section slows down browser & upload time significantly (not responding message sometimes appear)

• ✔️ as gunter - share the folder as viewer

• ✔️ as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)

• ✔️ as alice - try do delete file from shared folder
  - individual delete action not visible, good
  - batch delete action not visible, good
  - context menu action not visible, good

• ✔️ as alice - try to add file
  - not possible (which is expected) but drag & drop upload didn't handle it. opened file in new tab instead.

• ❌ as alice - copy 16 folders from share to home

  • no visible feedback that it's in progress
  • UI still weirdly usable, ended up in an active upload drop zone

• ✔️ as gunter - add new file to share

• ✔️ as alice - receive new file in existing share

• ✔️ as gunter - unshare folder from shared with others

• ✔️ as alice - try to revisit old share

  • shows resource not found upon page reload, good
  • going back to All files or Shared with me doesn't list the share anymore, good

• ✔️ as gunter - share folder with alice again, but as editor

• ✔️ as alice - rename file

  • via right sidebar, works, good
  • via context menu, works, good

• ✔️ as gunter - add file

• ✔️ as alice - delete file

  • via right sidebar, works, good
  • via context menu, works, good

• ✔️ as alice - create public link on any folder

• ✔️ as alice delete file and recover it

• ✔️ as alice create version of textfile

• ✔️ as alice view version history of text file

• ✔️ as alice download newest version of text file

• ✔️ download older version of text file

• ✔️ restore older version of text file

  • no visible feedback about the success
  • preview is not updated

• ✔️ as alice - upload avatar in classic UI

  • login as dave, having a share with alice
  • shared with others page loads and shows avatars

• ✔️ as alice, move a file into subfolder via drag and drop

• ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with gunter

[ScharfViktor]

Smoke test with ocis:
branch: branch release-4.2.0

Case 1: admin share folder(with file) to marie:

Admin:
x. upload big file 30gb
upload folder with 1000 files. Check pagination, count items per page
v upload folder "folder_to_share" with file.pdf
v share folder "folder_to_share" to marie with edit right
Marie:
v accept "folder_to_share"
rename "folder_to_share" (?admin don't see)
v upload new file "file.txt" to "folder_to_share" (admin see new file)
v rename file.pdf (use rigth click) (admin see that file changed name)
v try to move "folder_to_share" to "/" (400)
v copy "folder_to_share" to "/"
Admin:
v add new file.jpeg to "folder_to_share" (marie can see file without access)
v move file.pdf to "/" (marie can not see file.pdf)
v add new "file.txt" create new version. (marie can see new version)
Marie:
x can download both versions (!error 501)
v restore old version
Admin:
v change share "folder_to_share" from "edit" to "viewer" (marie cannot rename/move/delete/download file in folder and cannot create new document in the folder)
Marie:
x decline folder (but folder exist in Shares - bug)
Admin:
v delete folder "folder_to_share" (marie: folder Shares empty)

Case 2: admin share file to marie:

Admin:
v upload file.jpeg
v share file.jpeg to marie with rigth viewer (use main menu. find marie by email [email protected])
Marie:
v accept file (marie can open/download/copy file but cannot delete/move/rename)
v copy file to "/"
x open file in Mediaviewer - don't work:
server error: ocis_1 | 2021/09/14 13:48:55 http: superfluous response.WriteHeader call from github.com/cs3org/reva/internal/http/interceptors/log.(*responseLogger).WriteHeader (log.go:154) ocis_1 | {"level":"error","service":"webdav","error":"{\"id\":\"go.micro.client\",\"code\":408,\"detail\":\"context deadline exceeded\",\"status\":\"Request Timeout\"}","time":"2021-09-14T13:49:00Z","message":"could not get thumbnail"}
v download file
Admin:
v change share "file.jpeg" from "viewer" to "edit"(marie can open/download/copy/rename file)
Marie:
v rename file (admin don't see)
Admin:
v unshare "file.jpeg" (marie cannot see "file.jpeg" in Shares/Shared for me but see the copied file)

Case 3: admin create public links to folder

Admin:
v create folder "for upload"
v add link with name "to_upload" with role "Uploader" with pass and expiration date
v open link (can only upload)
v upload file (admin can see new file)
v refresh page(page is empty)
v change share "for upload" from "Uploader" to "edit" (don't see expiration date)
x open old link (it work as upload)
v open new link (can open/download/copy/rename/move files)
v admin add new file to "for upload"
v refresh link (file exist)
v admin change pass (refresh link)

Case 4: admin create link to file

Admin:
v create file png
v add link with main menu
v open link(can open, download, see)
v change link, add pass
v refresh page (input pass)
v delete link
v refresh page (resourse not found)
v delete file
v restore
v delete
v Empty trash

Case 5: create new user:

Admin:
v create new account "tom"
Tom:
v go to account
v change language
Admin:
v block user (Login Error access denied)
v delete user (Logon failed)
v logout

Remarks:

Viewing a file in mediaviewer sometimes fails (500 Error)
Download old version (issue is exists)
Content continues to exist in the folder after decline
Empty "expiration date" field when editing a public link #5807
Uploading (5gb and more) takes a very long time and stops after 10 min (refresh token). The file is partially downloaded

[kulmann]

Smoke test rc1 standalone against oc10

• ✔️ as gunter - upload arch/mips folder from linux kernel (1945 files)

  • progress bar is not sticky
  • expanding the upload progress section slows down browser & upload time significantly

• ✔️ as gunter - share the folder to alice as viewer
  - sharing is not possible before the upload finished (user invite field doesn't stay focussed)

• ✔️ as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)

• ✔️ as alice - try do delete file from shared folder
  - individual delete action not visible, good
  - batch delete action not visible, good
  - context menu action not visible, good

• ✔️ as alice - try to add file
  - not possible (which is expected) but drag & drop upload didn't handle it. opened file in new tab instead.

• ❌ as alice - copy 16 folders from share to home

  • no visible feedback that it's in progress
  • UI still weirdly usable, ended up in an active upload drop zone. folder listing after copy shows ? as folder size on some of the copied folders.

• ✔️ as gunter - add new file to share

• ✔️ as alice - receive new file in existing share

• ✔️ as gunter - unshare folder from shared with others

• ✔️ as alice - try to revisit old share

  • shows resource not found upon page reload, good
  • going back to All files or Shared with me doesn't list the share anymore, good

• ✔️ as gunter - share folder with alice again, but as editor

• ✔️ as alice - rename file

  • via right sidebar, works, good
  • via context menu, works, good

• ✔️ as gunter - add file

• ✔️ as alice - delete file

  • via right sidebar, works, good
  • via context menu, works, good

• ✔️ as alice - create public link on any folder

• ✔️ as alice delete file and recover it

• ✔️ as alice create version of textfile

• ✔️ as alice view version history of text file

• ✔️ as alice download newest version of text file

• ✔️ download older version of text file

• ✔️ restore older version of text file

  • no visible feedback about the success
  • preview is not updated

• ✔️ as alice - upload avatar in classic UI

  • login as dave, having a share with alice
  • shared with others page loads and shows avatars

• ✔️ as alice, move a file into subfolder via drag and drop

• ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with gunter

Findings from smoke testing:

• mouse drop event doesn't trigger the upload dropzone anymore. Instead the dropped file opens in a new tab and the web ui shows a successfully moved 0 items message. Drag & drop for move kills drag & drop for upload #5808
• coming back from mediaviewer doesn't highlight the selected file anymore in the files list