Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Files-Search option: "Current folder" #5419

Closed
exalate-issue-sync bot opened this issue Jun 30, 2021 · 3 comments · Fixed by #5415
Closed

Add Files-Search option: "Current folder" #5419

exalate-issue-sync bot opened this issue Jun 30, 2021 · 3 comments · Fixed by #5415
Labels

Comments

@exalate-issue-sync
Copy link

As a user i want to scope the files-search to my current folder, to easily spot the file I'm looking for in the current folder.

Acceptance Criteria

  • applies to oc10 + ocis
  • default: search scope is global (if available)
  • Option to select the current folder (without sub-folders) as search-scope. to be strict: this is filtering ;-)
  • happens client-side
  • when searchfield is not empty: show 2 options below search bar
  1. All files (serverside, not avialable on ocis)
  2. Current folder (client side / filter)

check github as an example

  • keyboard arrows up / down to select search scope
  • keyboard enter for firing the search/filter
    clicking option with mouse also fires the search/filter (check github for an expierience axample)
  • unit test in ODS
  • search bar component in ods: remove search button
  • placeholder text: "Search files and folders"
  • use oc-tag component for dropdown-option labeling (cf github)
  • use fuzzy search "fusejs.io"
  • current sorting is respected (only limit the set of activeFiles displayed in the current view)
  • pagination stays untouched

image.png

image.png
image.png

@exalate-issue-sync
Copy link
Author

Florian Schade commented: Ideas for later:

@exalate-issue-sync
Copy link
Author

Pascal Wengerter commented: [~tbaader] added a screenshot of GitLab's search UI for inspiration when it comes to our search page in the web UI sometime soon!

@exalate-issue-sync
Copy link
Author

Tobias Baader commented: Also Ideas for later:
Box search is imo quite well done:

  • option to open parent folder
  • shows last modified

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants