Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The via button sends you to the parent of the share entry #5082

Closed
labkode opened this issue May 7, 2021 · 8 comments · Fixed by #5122
Closed

The via button sends you to the parent of the share entry #5082

labkode opened this issue May 7, 2021 · 8 comments · Fixed by #5122
Labels
Category:Defect Existing functionality is not working as expected Early-Adopter:CERN

Comments

@labkode
Copy link

labkode commented May 7, 2021

The "Via" button send you to the parent of the share entry, however this folder may not be accessible to the user.
The "Via" button should send you the to share entry.

For example:

If I have received a share to folder Two, the user will see the following path:
/eos/user/d/diogo/One/Two/Three

If I am in Three and click "Via" button I get redirected to "One" where I should have been redirected to "Two".

@labkode
Copy link
Author

labkode commented May 21, 2021

Still reproducible from latest master.

@labkode labkode reopened this May 21, 2021
@kulmann
Copy link
Member

kulmann commented May 21, 2021

I just re-tested it from the current web master and can confirm the fix with an oc10 and an ocis backend. 🤔

1: Create a folder One
2: Create a subfolder One/Two
3: Upload a file image.jpg into One/Two/image.jpg
4: Share folder One/Two with user bob
5: Login as bob and accept the share - for bob it's now Two as a root level share
6: Open the right sidebar in People accordion item for Two/image.jpg
7: Click on Via Two
8: Land in Two

@labkode
Copy link
Author

labkode commented May 21, 2021

@kulmann

  1. You land in "Shares" not in Two.
via-panel.mov

@kulmann
Copy link
Member

kulmann commented May 21, 2021

@labkode ocis.owncloud.works is not deployed with web master, but only from ocis master (with the most recent web release). I will check internally if we can get an oCIS test system that has web from current master at least nightly.

@labkode
Copy link
Author

labkode commented May 21, 2021

@kulmann is the same behaviour on our deployment which uses latest version from web@master since yesterday.

@labkode
Copy link
Author

labkode commented May 21, 2021

@kulmann is it a config option maybe that we're missing?

@kulmann
Copy link
Member

kulmann commented May 21, 2021

Not related to config options. It's actually changed without exception. If you can still see the scrollTo in the URL, then it really is not the most recent master.

@labkode
Copy link
Author

labkode commented May 21, 2021

Fixed. Thanks!

@labkode labkode closed this as completed May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Defect Existing functionality is not working as expected Early-Adopter:CERN
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants