Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit #1 – General Overview when logged in – Items not reachable or interactive by keyboard #4333

Closed
marcus-herrmann opened this issue Nov 18, 2020 · 1 comment

Comments

@marcus-herrmann
Copy link
Contributor

marcus-herrmann commented Nov 18, 2020

Connected to Audit 1, see #4300
1.2 General Overview when logged in, URL: https://ocis-a11y.owncloud.works/#/files/list

Issue

Files and folders (see screenshot) are not reachable via keyboard only. Mobile: Bread crumb dropdown not reachable via keyboard
Xnip2020-11-18_13-05-08

Mobile (portrait mode) construct of collapsed bread crumbs is no button or link, just a div, even without a click event (a bug?)

"Rolle" Dropdown: Options are not keyboard accessible, only trigger is.

CleanShot 2021-02-24 at 11 43 17

In Account menu, only the third item (a button) is reachable via keyboard:
CleanShot 2021-02-24 at 12 33 14

This is because Profil and Settings are incomplete links (just <a><a/> without href attribute). Some browsers don't put these incomplete/invalid links into the tabindex, making them unreachable.

Remediation

Using (router-?)links for File and folders activator, which is currently just a clickable div. Using a or button should also remedy 2.5.2a.
Mobile (portrait mode) construct of collapsed bread crumbs: Depending on what is intended: disclosure widget? See: https://marcus.io/blog/disclosure-widget-vuejs
Using buttons for every single role option.
Using route links for Profil and Settings

@pascalwengerter
Copy link
Contributor

Closing this since #5018 is merged and we're waiting for feedback (and will open new tickets with the requested changes from the a11y audit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants