Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit #1 – General Overview when logged in – Home icon in bread crumb has no text, disclosure possibly needs aria-controls, "Personen hinzufügen" label points to div #4329

Closed
marcus-herrmann opened this issue Nov 18, 2020 · 1 comment

Comments

@marcus-herrmann
Copy link
Contributor

marcus-herrmann commented Nov 18, 2020

Connected to Audit 1, see #4300
1.2 General Overview when logged in, URL: https://ocis-a11y.owncloud.works/#/files/list

Issues

  • Starting point (home link) of bread crumb has no link text, neither visually nor programmatically.
  • "Personen hinzufügen" is a <label>, but points (via for) to a <div>instead of an input.

Remediations

aria-label, aria-labelledby or hidden text for screen readers via .visually-hidden/.sr-only, see https://a11y-guidelines.orange.com/en/web/components-examples/accessible-hiding/

Update: the general disclosure widget pattern

The attribute aria-controls connects an interface item that triggers a change to an interface item that reacts to a change. As of 2021, no current screen reader supports this attribute. BITV/WCAG testers could require the attribute nevertheless. In this case, it could be needed to rework all disclosure widgets in the app, as following:

<button aria-expanded="true|false" aria-controls="container">Click me</button>
<div id="container" [hidden attribute, depending on state]>I'm conditionally visible</div>
@marcus-herrmann marcus-herrmann changed the title Audit #1 – General Overview when logged in – Home icon in bread crumb has no text Audit #1 – General Overview when logged in – Home icon in bread crumb has no text, disclosure possibly needs aria-controls, "Personen hinzufügen" input has no label Feb 24, 2021
@marcus-herrmann marcus-herrmann changed the title Audit #1 – General Overview when logged in – Home icon in bread crumb has no text, disclosure possibly needs aria-controls, "Personen hinzufügen" input has no label Audit #1 – General Overview when logged in – Home icon in bread crumb has no text, disclosure possibly needs aria-controls, "Personen hinzufügen" label points to div Feb 24, 2021
@pascalwengerter
Copy link
Contributor

Closing this since #5018 is merged and we're waiting for feedback (and will open new tickets with the requested changes from the a11y audit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants