Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of scaffolding including docs, blog and stuff. #268

Closed
DeepDiver1975 opened this issue Oct 12, 2018 · 6 comments
Closed

Cleanup of scaffolding including docs, blog and stuff. #268

DeepDiver1975 opened this issue Oct 12, 2018 · 6 comments
Assignees

Comments

@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Oct 12, 2018

Story:
Give a developer want to work on Phoenix
....

Tasks:

  • Final decision on vuetify vs uikit
  • Cleanup of naming (uppercase function names - WTF) - partially addressed in oauth pr
  • Cleanup on template language, script language and style language (keep it simple? html + ecma5 + css)
  • Introduce style tools into drone - eslint

Total effort: 2 MD

@tempelgogo
Copy link
Contributor

tempelgogo commented Oct 17, 2018

Regarding to your Introduce style tools into drone - eslint task:
Do we prefer https://standardjs.com/ or https://github.com/airbnb/javascript style guide?

The initial fix could make some trouble - we can use the eslint autofix feature, but it's a big commit which is incredible hard to merge if the files are changed elsewhere.
Do you want us to autofix all source files to fit into the eslint style ?

Do we want to use git commit hooks to auto-lint before commit :) ?

@DeepDiver1975
Copy link
Member Author

Do we prefer https://standardjs.com/

I'd go for this one ... no semi-collon ... really ....

@PVince81 ^

@PVince81
Copy link
Contributor

@DeepDiver1975 I like my semicolons... but if everyone votes against I'm fine

@scramb
Copy link
Contributor

scramb commented Oct 18, 2018

The one without semicolon would be my choice.

@DeepDiver1975
Copy link
Member Author

okay - lets got for standardjs.com then.

Please add the style + check on drone + one time fix the style on the code base
no auto fix on commit or something - devs have to learn ;-)

@tempelgogo
Copy link
Contributor

outsourced blog task into #464

So it seems, that all requirements of this issue are fulfilled.
I therefore take the liberty of closing this issue; please reopen it at any time if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants