Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance tests for uploads #2222

Closed
LukasHirt opened this issue Oct 11, 2019 · 5 comments
Closed

Acceptance tests for uploads #2222

LukasHirt opened this issue Oct 11, 2019 · 5 comments

Comments

@LukasHirt
Copy link
Collaborator

Currently we test only file upload. Folders needs to be added as well.

@LukasHirt LukasHirt added this to the backlog milestone Oct 11, 2019
@PVince81 PVince81 changed the title Acceptance tests for folder upload Acceptance tests for uploads Oct 15, 2019
@PVince81
Copy link
Contributor

PVince81 commented Oct 15, 2019

  • All files
    • using "+ New" button
      • single file upload into root
      • single file upload into subdirectory
      • folder upload into subdirectory
    • using drag and drop
      • single file upload into root
      • single file upload into subdirectory
      • folder upload into subdirectory
    • uploading folder containing empty folder entries: empty folder entries do NOT appear (not supported, known limitation) (Not possible due to limitation in git)
  • Public link
    • using "+ New" button
      • single file upload into root
      • single file upload into subdirectory
      • folder upload into subdirectory
    • using drag and drop
      • single file upload into root
      • single file upload into subdirectory
      • folder upload into subdirectory
  • Files drop (upload-only public link)
    • using "+ New" button
      • single file upload into root
      • single file upload into subdirectory (Not implemented)
      • folder upload into subdirectory (Not implemented)
    • using drag and drop
      • single file upload into root
      • single file upload into subdirectory
      • folder upload into subdirectory
  • smoke test IE11: single file upload with "all files" into subdirectory (cannot mount as we run inside saucelabs)

@individual-it

@skshetry
Copy link
Member

@PVince81, simple uploads of files and folders are complete.

"Empty folders" test is not possible at the moment, as we use the filesForUpload that is checked out in git (and, git doesnot support empty folders).

I have not invested much time in drag-and-drop, as it's not supported by selenium (but, can be simulated, but that way, I feel it will be closely coupled to the drag-and-drop implementation, so, we will be simulating drag and drops and will only be testing the file uploads).

@individual-it
Copy link
Member

I tried tests for dragging an element into phoenix but did not succeed see #1302

@LukasHirt @PVince81 should we close this issue?

@LukasHirt
Copy link
Collaborator Author

I'd still like to keep this open. Having the drop upload feature untested seems rather scary to me. I guess I or @PVince81 could schedule some time in some upcoming sprint to look into this if we'd find a way.

@pascalwengerter
Copy link
Contributor

@ScharfViktor I'll assign this to you, maybe we can add this to the smoke tests once they run in CI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants