Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File viewer and editors #215

Closed
PVince81 opened this issue Aug 10, 2018 · 6 comments
Closed

File viewer and editors #215

PVince81 opened this issue Aug 10, 2018 · 6 comments
Labels
Category:Enhancement Add new functionality
Milestone

Comments

@PVince81
Copy link
Contributor

PVince81 commented Aug 10, 2018

Story:
Given a developer want to add an action to open a file in another tool
When the app code registers a file action for text files
Then the action shall be visible on text files

When a user executes the file action
Then app code is to be executed or a given url is to be opened (in another tab)

Tasks:

  • implement file action + viewer concept in phoenix files app (3MD)
  • implement an app to show (text editor which opens a text file in new browser tab) (2MD)

Like owncloud/core#13414.

Provide an extension point of some form where apps can register their own "file viewer" for different formats.
This will tie in somehow with the file actions

Please add input as we need to decide on the UX for this.

One proposal was to always have apps open their viewer in a separate page.
This also means the separate page needs to have some layout and styling from Phoenix.

@felixheidecke @DeepDiver1975 @tomneedham @pmaier1

@PVince81 PVince81 added the Category:Enhancement Add new functionality label Aug 10, 2018
@PVince81 PVince81 added this to the backlog milestone Aug 10, 2018
@PVince81 PVince81 changed the title File viewer File viewer and editors Aug 10, 2018
@tomneedham
Copy link

Random thoughts:

  • Open in new window (new tab if clicked with ctrl+click), no 'inline' editors
  • Back button returns to file list, scrolled to the same location
  • Needs a similar 'registerActions' type handler for mime registration
    • On that thought, as an admin some global preferred handler config might be nice
  • At least how we do it now, each editor should have a route, which accepts a fileid (eg, now I have /apps/drawio/editor/{fielid}
  • New persistent locking is most likely needed to give a nice UX
    • Seeing who is currently editing this file (who owns the lock) would be awesome

@PVince81
Copy link
Contributor Author

Also to discuss, providing a framework:

  • how to handle read-only vs read-write mode ?
  • what about additional permissions like "comments only" (Collabora and OnlyOffice)
  • also think about public link page

@tomneedham
Copy link

what about additional permissions like "comments only" (Collabora and OnlyOffice)

Like 'review' permissions - could be cool

@DeepDiver1975
Copy link
Member

I don't see a way to integrate app driven/defined permissions to be handled in core. At least I did not have a clever idea ....

@PVince81
Copy link
Contributor Author

also need to make sure file viewer works in public page

@DeepDiver1975
Copy link
Member

There is a markdown editor in phoenix which shows how an editor can be integrated. closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

No branches or pull requests

3 participants