Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Reason to add xmldom to Dependecy #938

Closed
jeremia49 opened this issue Nov 24, 2021 · 1 comment
Closed

Reason to add xmldom to Dependecy #938

jeremia49 opened this issue Nov 24, 2021 · 1 comment

Comments

@jeremia49
Copy link
Contributor

jeremia49 commented Nov 24, 2021 •
edited
Loading

Are there any reason to add xmldom to dependecy ?
I tried to remove the xmldom and ran the consumer tests locally, and it turns out it PASS the tests.

If there are some reason to use xmldom, you should replace it to https://github.com/xmldom/xmldom because jindw/xmldom#259

GH-908
@jeremia49 jeremia49 mentioned this issue Nov 24, 2021
Merged
@pascalwengerter
Copy link
Contributor

Closed via #939 thanks to @jeremia49

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pascalwengerter @jeremia49