Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Small bugs in ODS 1.10.1 #877

Closed
1 task
kulmann opened this issue Sep 17, 2020 · 5 comments
Closed
1 task

Small bugs in ODS 1.10.1 #877

kulmann opened this issue Sep 17, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented Sep 17, 2020

ODS 1.10.1 has some visual bugs that need fixing. This is a collection of it, including screenshots.

  • borders around focused raw buttons (borders need to be removed). Actually, all buttons are affected. It's just more obvious on raw buttons. It should be sufficient to have the highlighted color only for :hover, not for :focus.

Screenshot 2020-09-17 at 17 45 53

@kulmann kulmann added the bug Something isn't working label Sep 17, 2020
@kulmann
Copy link
Member Author

kulmann commented Sep 17, 2020

I propose to use display: inline-flex; instead of display: flex; on oc-buttons. Otherwise we'll have to take care of re-layouting all buttons in any location, since they are handles as block elements and will cause line breaks.

@LukasHirt
Copy link
Collaborator

LukasHirt commented Sep 18, 2020

The focus is actually on purpose due to accessibility #445. Just needs to be styled properly - the current one is default styling.

@kulmann
Copy link
Member Author

kulmann commented Sep 18, 2020

Oh wow... I get the point, but I think that needs to be less obtrusive. Did you also consider some dropshadow, very thin border, etc?

@LukasHirt
Copy link
Collaborator

LukasHirt commented Sep 18, 2020

Agree that it should be as subtle as possible but on the other hand, we need to consider people with visual impairments. What we discussed once was the option to visualise the focus only if it was done via the keyboard, not when clicking on elements.

@kulmann
Copy link
Member Author

kulmann commented Sep 22, 2020

Closing in favor of owncloud/web#3046 (focus border is important, but should only be visible when using the keyboard, not when clicking on something with the mouse).

@kulmann kulmann closed this as completed Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants