Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Broken sidebar navigation in Design Docs / on owncloud.design #812

Open
LukasHirt opened this issue Jul 15, 2020 · 3 comments · Fixed by #1150
Open

Broken sidebar navigation in Design Docs / on owncloud.design #812

LukasHirt opened this issue Jul 15, 2020 · 3 comments · Fixed by #1150
Labels
bug Something isn't working

Comments

@LukasHirt
Copy link
Collaborator

For a long time, there is broken navigation in the sidebar. To display sub-items we need to either click twice on the parent item or we need to refresh the page. This is caused because the hiding/displaying of sub-items is handled via custom logic but the way how the docs are rendered has changed. We can try to investigate time to fixing this custom logic or we can use the default behaviour of styleguidist. Upstream has an opened ticket about this but it seems that the project is not active at all anymore.

@LukasHirt LukasHirt added the bug Something isn't working label Jul 15, 2020
@kulmann
Copy link
Member

kulmann commented Jul 16, 2020

yes, this was bugging me as well... important to have working documentation for both community and ourselves => we should schedule time for this 👍

@rpocklin
Copy link
Contributor

I found this today and was going to raise it as a new issue, found it already exists.

Would be great to fix, I thought I was doing something wrong for a bit.

Here is a video (watch until the end for the clearest example)
I would say there is some bad event handling or double-event binding going on (or perhaps a timing issue).

owncloud-design-com-sidebar-click-event-issue.zip

@LukasHirt
Copy link
Collaborator Author

I would say there is some bad event handling or double-event binding going on (or perhaps a timing issue)

Yep, I was once trying to debug why it's happening and found out there is some re-render taking place after the custom logic for displaying sub menus. This started happening after an update of vue-styleguidist which handles navigation differently than us.

@kulmann kulmann reopened this Mar 15, 2021
@pascalwengerter pascalwengerter changed the title Broken sidebar navigation Broken sidebar navigation in Design Docs / on owncloud.design Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants