-
Notifications
You must be signed in to change notification settings - Fork 19
Missing icons for external applications #2071
Comments
What's wrong with the currently provided DrawIO icon? Also, what's the usecase for the icons you're asking for? Usually the external apps registered through the appProvider (in the oCIS use case) should provide their own icons, which is already the case for e.g. Collabora as seen below on https://ocis.ocis-web.latest.owncloud.works/ |
By us, each app_provider inside the mimetypes array has "icon" property, which is the name of the icon from ods. We previously had urls of icons placed on external pages, but decided against the external requests. I can't test ocis-web.latest right now (seems broken), can providing icons be done differently than with external urls? |
As discussed in a call, one option would be to allow registering additional icons in the design system a) via theming in web and b) from app manifests. I.e. provide key-value-pairs of icon names and asset urls, inject them to the ODS during ODS init in the web runtime. The main issue here is that we can't just simply add any icon to our design system because of copyright / license issue. Anything that is not compatible license wise needs to be added during runtime. |
@kulmann @pascalwengerter Short term we will use links for icons. But could the drawio app icon still be added into ods? Right now it's missing, there is only the generic app icon. I don't know if the license is alright, should maybe redraw it based on drawio file icon? |
adjusted the public domain licenced icon from wikipedia to our svg-icon size: |
The licences need to be checked
The text was updated successfully, but these errors were encountered: