Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] add default search fields #4585

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Sep 14, 2022

Description

till now search only respects the "name" field when using the search, this pr extends the fields to "Content" (tika), "Tags" and "Name". It also introduces a simple lexer which supports the ios query dictonary

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Sep 14, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

services/search/pkg/engine/bleve.go Outdated Show resolved Hide resolved
services/search/pkg/query/lexer.go Show resolved Hide resolved
@fschade fschade marked this pull request as ready for review September 15, 2022 12:44
add lexer to parse query
make search query case-insensitive
remove tests for not allowed search fields
@fschade fschade force-pushed the search-default-fields branch 3 times, most recently from ca6241b to 7358af7 Compare September 16, 2022 10:21
@fschade fschade force-pushed the search-default-fields branch from 7358af7 to 3427db3 Compare September 16, 2022 10:38
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

97.1% 97.1% Coverage
0.0% 0.0% Duplication

@fschade fschade merged commit e72e9ae into experimental Sep 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the search-default-fields branch September 16, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants