Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activities. Any user can get the resource's activities using the file-id #9860

Closed
prashant-gurung899 opened this issue Aug 20, 2024 · 2 comments · Fixed by #10092
Closed
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug

Comments

@prashant-gurung899
Copy link
Contributor

Similar to: #9849

Steps to reproduce

  1. create a folder as alice user

  2. as alice, create some files and perform some actions (edit/delete) in folder

  3. as demo user, check the folder activities using resource(folder) id with cURL request:

    curl 'https://localhost:9200/graph/v1beta1/extensions/org.libregraph/activities?kql=itemid%3A{folder-fileid}' \
    -udemo:demo -vk | jq
    
    {"value": [
      {
       ... # activities
      }
    ]}

Expected behavior

Expected not to get the list of activities when requested by random user.

Actual behavior

Gets the list of all the activities in the folder.

@ScharfViktor
Copy link
Contributor

I prioritized as prio2 because IMHO it's the security hole

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Sep 18, 2024

Steps:

  • admin shares folder f1 to einstein
  • einstein opens folder f1 in the Shares -> copy spaceId from Propfind response body
  • put spaceuuid to
curl 'https://localhost:9200/graph/v1beta1/extensions/org.libregraph/activities?kql=itemid%3A{spaceUUId}' \
-ueinstein:relativity -vk | jq

expected: 403 error

Actual: einstein can see all action of the admin personal space 🤯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants