Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reva] Delete expired Public Shares #372

Closed
refs opened this issue Jul 9, 2020 · 2 comments
Closed

[Reva] Delete expired Public Shares #372

refs opened this issue Jul 9, 2020 · 2 comments
Assignees
Labels

Comments

@refs
Copy link
Member

refs commented Jul 9, 2020

Public Links shares are not yet being deleted when they expire, instead, they're not being returned from the API call. This means you can still access a publicly shared resource as long as you keep the URL. This is a bug.

Useful information:

Transcript from @PVince81:

in OC10 we delete the shares on demand if they are expired. I'd tend to want the logic in shares.go and not json.go

@exalate-issue-sync
Copy link

Alex Unger commented: I can take over this one. I opened a PR some time ago about this: cs3org/reva#959

@exalate-issue-sync
Copy link

Alex Unger commented: This has been reworked into cs3org/reva#1361

The approach followed is to tackle public share deletion directly on the shares manager instead of the grpc service to spare API calls to delete shares.

Disclaimer: all managers (json + memory) need to be updated, since memory is not used, from this point on, any new public share manager implementation MUST delete shares on list to prevent them to be on the response, and cleanup the "database".

@exalate-issue-sync exalate-issue-sync bot changed the title Delete expired Public Shares [Reva] Delete expired Public Shares Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant