Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU load while playing. Please review issue #131 #137

Closed
lazarus123 opened this issue Jan 4, 2014 · 4 comments
Closed

CPU load while playing. Please review issue #131 #137

lazarus123 opened this issue Jan 4, 2014 · 4 comments
Milestone

Comments

@lazarus123
Copy link

As issue #131 was closed, I create this.

Tested this latest release and the problem isnt solved completely unfortunately. On my machine with Intel(R) Core(TM) i5-3337U CPU @ 1.80GHz and Firefox 26 and collection of approx 10k songs each refresh takes closer to 1000ms, so it is running in this refresh loop continuously.
I set the flashPollingInterval: 10000 and html5PollingInterval: 10000, This makes it usable in Chrome but Firefox doesnt seem to care about these parameters :(

This is my way of fixing it in both. (obiously wont be usable for anyone else ;) (ten seconds )

if(!($scope.$$phase || Math.abs(position - $scope.position) < 10)) {

    $scope.$apply(function(){
        $scope.duration = duration;
        $scope.position = position;
    });
}

Maybe find another way to do the refreshes ? Dunno.

Thank you.

@HLFH
Copy link

HLFH commented Jan 4, 2014

@lazarus123 duplicate of #90 ?

@lazarus123
Copy link
Author

Not really, as #90 is about first loading and indexing your music files. This issue is when you are actually listening to the music.

@MorrisJobke
Copy link
Contributor

The problem with this approach is, that the progress bar gets updated once every ten seconds ...

@MorrisJobke
Copy link
Contributor

This could propably be fixed with de85928 (see #90 (comment))

I have remove the bindings to the current position. This caused huge lags on the web interface. I supposed that angular tested all the binding updates every second.

Can you please report if this is not fixed for you. I will reopen it then.

@MorrisJobke MorrisJobke added this to the First release candidate milestone Mar 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants